Fix: swap pickup notes for rider_notes on campaign singup. #349
Conversation
| @@ -23,8 +23,8 @@ | |||
| <:col :let={task} label="Dropoff Neighbourhood"> | |||
| <%= Locations.neighborhood(task.dropoff_location) %> | |||
| </:col> | |||
| <:col :let={task} label="Notes"><%= task.delivery_status_notes %> | |||
There was a problem hiding this comment.
While swapping this, I noticed that for some reasons I added the delivery_status_notes into this html table. 🧹
|
Just to be clear we haven't added any form to fill them in yet right? |
I did actually add it to the task form. I should have added a screenshot:
|
|
Oh sorry, I missed the html bits. To be honest, I'm not 100% sure on this: I think the issue that this has PII and should be hidden from the public page should be addressed. I think before adding a separate field we should iterate on clear instructions and train dispatchers e.g. I notice there's a todo to rename the field from rider notes to delivery instructions. What if we make a PR to hide it and then get some feedbakc on slack on copy for adding a second field? |
|
Sure, I'll make a PR to hide the delivery notes for now and then we can circle back to this when necessary :) |
Fixes #340